From 10416a73204fc47ac0efb02937eb4093892f0b6e Mon Sep 17 00:00:00 2001 From: Benjamin Solum Date: Sat, 28 Feb 2015 14:39:52 -0600 Subject: [PATCH 01/14] Removed white space char that breaks validation The extra newline char between and the tag breaks what would otherwise be a valid feed. It's only there for aesthetic reasons anyway so it should be removed. --- lib/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/index.js b/lib/index.js index e9fa9ce..07ed334 100755 --- a/lib/index.js +++ b/lib/index.js @@ -181,7 +181,7 @@ function RSS (options, items) { }; this.xml = function(indent) { - return '\n' + + return '' + xml(generateXML(this), indent); }; } From 84a32507793ea96406ecc740c971ce86d700a758 Mon Sep 17 00:00:00 2001 From: Benjamin Solum Date: Sat, 28 Feb 2015 17:12:07 -0600 Subject: [PATCH 02/14] Update customElements.xml --- test/expectedOutput/customElements.xml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/test/expectedOutput/customElements.xml b/test/expectedOutput/customElements.xml index fa3d1aa..2ab3512 100644 --- a/test/expectedOutput/customElements.xml +++ b/test/expectedOutput/customElements.xml @@ -1,5 +1,4 @@ - - + <![CDATA[title]]> @@ -35,4 +34,4 @@ 7:04 - \ No newline at end of file + From 481b1eb8ec2cb321de54277826607100a3203131 Mon Sep 17 00:00:00 2001 From: Benjamin Solum Date: Sat, 28 Feb 2015 17:12:23 -0600 Subject: [PATCH 03/14] Update customNamespaces.xml --- test/expectedOutput/customNamespaces.xml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/test/expectedOutput/customNamespaces.xml b/test/expectedOutput/customNamespaces.xml index fc3684d..152d3da 100644 --- a/test/expectedOutput/customNamespaces.xml +++ b/test/expectedOutput/customNamespaces.xml @@ -1,5 +1,4 @@ - - + <![CDATA[title]]> @@ -35,4 +34,4 @@ 7:04 - \ No newline at end of file + From 27595cbf6ac143f3d21c6f65818145e5bbf04f8a Mon Sep 17 00:00:00 2001 From: Benjamin Solum Date: Sat, 28 Feb 2015 17:12:41 -0600 Subject: [PATCH 04/14] Update default.xml --- test/expectedOutput/default.xml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/test/expectedOutput/default.xml b/test/expectedOutput/default.xml index 3f2ba69..db51512 100644 --- a/test/expectedOutput/default.xml +++ b/test/expectedOutput/default.xml @@ -1,2 +1 @@ - -<![CDATA[Untitled RSS Feed]]>http://github.com/dylang/node-rssRSS for NodeWed, 10 Dec 2014 19:04:57 GMT \ No newline at end of file +<![CDATA[Untitled RSS Feed]]>http://github.com/dylang/node-rssRSS for NodeWed, 10 Dec 2014 19:04:57 GMT From 03c38cee323c130c0feb2a27b98717d0b23a40a1 Mon Sep 17 00:00:00 2001 From: Benjamin Solum Date: Sat, 28 Feb 2015 17:12:51 -0600 Subject: [PATCH 05/14] Update defaultOneItem.xml --- test/expectedOutput/defaultOneItem.xml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/test/expectedOutput/defaultOneItem.xml b/test/expectedOutput/defaultOneItem.xml index 422e49f..b91749b 100644 --- a/test/expectedOutput/defaultOneItem.xml +++ b/test/expectedOutput/defaultOneItem.xml @@ -1,2 +1 @@ - -<![CDATA[Untitled RSS Feed]]>http://github.com/dylang/node-rssRSS for NodeWed, 10 Dec 2014 19:04:57 GMT<![CDATA[No title]]>No title \ No newline at end of file +<![CDATA[Untitled RSS Feed]]>http://github.com/dylang/node-rssRSS for NodeWed, 10 Dec 2014 19:04:57 GMT<![CDATA[No title]]>No title From cd3f4d8f276c124a1c54b5bb2bea4c1acdd247d9 Mon Sep 17 00:00:00 2001 From: Benjamin Solum Date: Sat, 28 Feb 2015 17:13:04 -0600 Subject: [PATCH 06/14] Update enclosures.xml --- test/expectedOutput/enclosures.xml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/test/expectedOutput/enclosures.xml b/test/expectedOutput/enclosures.xml index de9d6d2..a1084a3 100644 --- a/test/expectedOutput/enclosures.xml +++ b/test/expectedOutput/enclosures.xml @@ -1,5 +1,4 @@ - - + <![CDATA[title]]> @@ -35,4 +34,4 @@ - \ No newline at end of file + From ae3f58af49a0620130ba4da8fbe3d335f2103556 Mon Sep 17 00:00:00 2001 From: Benjamin Solum Date: Sat, 28 Feb 2015 17:13:17 -0600 Subject: [PATCH 07/14] Update latLong.xml --- test/expectedOutput/latLong.xml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/test/expectedOutput/latLong.xml b/test/expectedOutput/latLong.xml index 5c1d827..b4f17a5 100644 --- a/test/expectedOutput/latLong.xml +++ b/test/expectedOutput/latLong.xml @@ -1,5 +1,4 @@ - - + <![CDATA[title]]> @@ -27,4 +26,4 @@ Thu, 24 May 2012 04:00:00 GMT - \ No newline at end of file + From 2ff9dbe66ed387b76f18075596a8eaf1b1b4b19b Mon Sep 17 00:00:00 2001 From: Benjamin Solum Date: Sat, 28 Feb 2015 17:13:29 -0600 Subject: [PATCH 08/14] Update pubSubHubbub.xml --- test/expectedOutput/pubSubHubbub.xml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/test/expectedOutput/pubSubHubbub.xml b/test/expectedOutput/pubSubHubbub.xml index 185c64d..aa67fa3 100644 --- a/test/expectedOutput/pubSubHubbub.xml +++ b/test/expectedOutput/pubSubHubbub.xml @@ -1,5 +1,4 @@ - - + <![CDATA[title]]> @@ -9,4 +8,4 @@ - \ No newline at end of file + From 3977033166168b3c81888db17cde6cd21286c5f6 Mon Sep 17 00:00:00 2001 From: Benjamin Solum Date: Sat, 28 Feb 2015 17:13:39 -0600 Subject: [PATCH 09/14] Update simpleFeed.xml --- test/expectedOutput/simpleFeed.xml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/test/expectedOutput/simpleFeed.xml b/test/expectedOutput/simpleFeed.xml index a63efad..f85058b 100644 --- a/test/expectedOutput/simpleFeed.xml +++ b/test/expectedOutput/simpleFeed.xml @@ -1,2 +1 @@ - -<![CDATA[title]]>http://example.comhttp://example.com/icon.pngtitlehttp://example.comExample GeneratorWed, 10 Dec 2014 19:04:57 GMTSun, 20 May 2012 04:00:00 GMThttp://example.com/rss/docs.html60<![CDATA[item 1]]>http://example.com/article1http://example.com/article1Thu, 24 May 2012 04:00:00 GMT<![CDATA[item 2]]>http://example.com/article2http://example.com/article2Fri, 25 May 2012 04:00:00 GMT<![CDATA[item 3]]>http://example.com/article3item3Sat, 26 May 2012 04:00:00 GMT<![CDATA[item 4 & html test with <strong>]]>html]]>http://example.com/article4?this&thathttp://example.com/article4?this&thatSun, 27 May 2012 04:00:00 GMT<![CDATA[item 5 & test for categories]]>http://example.com/article5http://example.com/article5Mon, 28 May 2012 04:00:00 GMT \ No newline at end of file +<![CDATA[title]]>http://example.comhttp://example.com/icon.pngtitlehttp://example.comExample GeneratorWed, 10 Dec 2014 19:04:57 GMTSun, 20 May 2012 04:00:00 GMThttp://example.com/rss/docs.html60<![CDATA[item 1]]>http://example.com/article1http://example.com/article1Thu, 24 May 2012 04:00:00 GMT<![CDATA[item 2]]>http://example.com/article2http://example.com/article2Fri, 25 May 2012 04:00:00 GMT<![CDATA[item 3]]>http://example.com/article3item3Sat, 26 May 2012 04:00:00 GMT<![CDATA[item 4 & html test with <strong>]]>html]]>http://example.com/article4?this&thathttp://example.com/article4?this&thatSun, 27 May 2012 04:00:00 GMT<![CDATA[item 5 & test for categories]]>http://example.com/article5http://example.com/article5Mon, 28 May 2012 04:00:00 GMT From a0e2f9ea8f4bb73d197a11fc636d607b85e355c4 Mon Sep 17 00:00:00 2001 From: Benjamin Solum Date: Sat, 28 Feb 2015 17:13:50 -0600 Subject: [PATCH 10/14] Update simpleFeedFormated.xml --- test/expectedOutput/simpleFeedFormated.xml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/test/expectedOutput/simpleFeedFormated.xml b/test/expectedOutput/simpleFeedFormated.xml index aa5df69..d695919 100644 --- a/test/expectedOutput/simpleFeedFormated.xml +++ b/test/expectedOutput/simpleFeedFormated.xml @@ -1,5 +1,4 @@ - - + <![CDATA[title]]> @@ -68,4 +67,4 @@ Mon, 28 May 2012 04:00:00 GMT - \ No newline at end of file + From 26f0508258da98c84212919b0b69c49fc11d9f4b Mon Sep 17 00:00:00 2001 From: Benjamin Solum Date: Sat, 28 Feb 2015 18:25:41 -0600 Subject: [PATCH 11/14] Update customElements.xml From c5dac2764f0195a9ed429d86e6c86d88683475dc Mon Sep 17 00:00:00 2001 From: Benjamin Solum Date: Sat, 28 Feb 2015 18:26:30 -0600 Subject: [PATCH 12/14] Update customNamespaces.xml From bf37e4caf3ca35c660c618a82763056aa13c825d Mon Sep 17 00:00:00 2001 From: Benjamin Solum Date: Sat, 28 Feb 2015 18:31:03 -0600 Subject: [PATCH 13/14] Removed newlines at end, should pass tests now. --- test/expectedOutput/customElements.xml | 2 +- test/expectedOutput/customNamespaces.xml | 2 +- test/expectedOutput/default.xml | 2 +- test/expectedOutput/defaultOneItem.xml | 2 +- test/expectedOutput/enclosures.xml | 2 +- test/expectedOutput/latLong.xml | 2 +- test/expectedOutput/pubSubHubbub.xml | 2 +- test/expectedOutput/simpleFeed.xml | 2 +- test/expectedOutput/simpleFeedFormated.xml | 2 +- 9 files changed, 9 insertions(+), 9 deletions(-) diff --git a/test/expectedOutput/customElements.xml b/test/expectedOutput/customElements.xml index 2ab3512..fed80ae 100644 --- a/test/expectedOutput/customElements.xml +++ b/test/expectedOutput/customElements.xml @@ -34,4 +34,4 @@ 7:04 - + \ No newline at end of file diff --git a/test/expectedOutput/customNamespaces.xml b/test/expectedOutput/customNamespaces.xml index 152d3da..7fe75b6 100644 --- a/test/expectedOutput/customNamespaces.xml +++ b/test/expectedOutput/customNamespaces.xml @@ -34,4 +34,4 @@ 7:04 - + \ No newline at end of file diff --git a/test/expectedOutput/default.xml b/test/expectedOutput/default.xml index db51512..f3cec4b 100644 --- a/test/expectedOutput/default.xml +++ b/test/expectedOutput/default.xml @@ -1 +1 @@ -<![CDATA[Untitled RSS Feed]]>http://github.com/dylang/node-rssRSS for NodeWed, 10 Dec 2014 19:04:57 GMT +<![CDATA[Untitled RSS Feed]]>http://github.com/dylang/node-rssRSS for NodeWed, 10 Dec 2014 19:04:57 GMT \ No newline at end of file diff --git a/test/expectedOutput/defaultOneItem.xml b/test/expectedOutput/defaultOneItem.xml index b91749b..bd3ffdc 100644 --- a/test/expectedOutput/defaultOneItem.xml +++ b/test/expectedOutput/defaultOneItem.xml @@ -1 +1 @@ -<![CDATA[Untitled RSS Feed]]>http://github.com/dylang/node-rssRSS for NodeWed, 10 Dec 2014 19:04:57 GMT<![CDATA[No title]]>No title +<![CDATA[Untitled RSS Feed]]>http://github.com/dylang/node-rssRSS for NodeWed, 10 Dec 2014 19:04:57 GMT<![CDATA[No title]]>No title \ No newline at end of file diff --git a/test/expectedOutput/enclosures.xml b/test/expectedOutput/enclosures.xml index a1084a3..be32a38 100644 --- a/test/expectedOutput/enclosures.xml +++ b/test/expectedOutput/enclosures.xml @@ -34,4 +34,4 @@ - + \ No newline at end of file diff --git a/test/expectedOutput/latLong.xml b/test/expectedOutput/latLong.xml index b4f17a5..7183953 100644 --- a/test/expectedOutput/latLong.xml +++ b/test/expectedOutput/latLong.xml @@ -26,4 +26,4 @@ Thu, 24 May 2012 04:00:00 GMT - + \ No newline at end of file diff --git a/test/expectedOutput/pubSubHubbub.xml b/test/expectedOutput/pubSubHubbub.xml index aa67fa3..dafc2a1 100644 --- a/test/expectedOutput/pubSubHubbub.xml +++ b/test/expectedOutput/pubSubHubbub.xml @@ -8,4 +8,4 @@ - + \ No newline at end of file diff --git a/test/expectedOutput/simpleFeed.xml b/test/expectedOutput/simpleFeed.xml index f85058b..7db75e8 100644 --- a/test/expectedOutput/simpleFeed.xml +++ b/test/expectedOutput/simpleFeed.xml @@ -1 +1 @@ -<![CDATA[title]]>http://example.comhttp://example.com/icon.pngtitlehttp://example.comExample GeneratorWed, 10 Dec 2014 19:04:57 GMTSun, 20 May 2012 04:00:00 GMThttp://example.com/rss/docs.html60<![CDATA[item 1]]>http://example.com/article1http://example.com/article1Thu, 24 May 2012 04:00:00 GMT<![CDATA[item 2]]>http://example.com/article2http://example.com/article2Fri, 25 May 2012 04:00:00 GMT<![CDATA[item 3]]>http://example.com/article3item3Sat, 26 May 2012 04:00:00 GMT<![CDATA[item 4 & html test with <strong>]]>html]]>http://example.com/article4?this&thathttp://example.com/article4?this&thatSun, 27 May 2012 04:00:00 GMT<![CDATA[item 5 & test for categories]]>http://example.com/article5http://example.com/article5Mon, 28 May 2012 04:00:00 GMT +<![CDATA[title]]>http://example.comhttp://example.com/icon.pngtitlehttp://example.comExample GeneratorWed, 10 Dec 2014 19:04:57 GMTSun, 20 May 2012 04:00:00 GMThttp://example.com/rss/docs.html60<![CDATA[item 1]]>http://example.com/article1http://example.com/article1Thu, 24 May 2012 04:00:00 GMT<![CDATA[item 2]]>http://example.com/article2http://example.com/article2Fri, 25 May 2012 04:00:00 GMT<![CDATA[item 3]]>http://example.com/article3item3Sat, 26 May 2012 04:00:00 GMT<![CDATA[item 4 & html test with <strong>]]>html]]>http://example.com/article4?this&thathttp://example.com/article4?this&thatSun, 27 May 2012 04:00:00 GMT<![CDATA[item 5 & test for categories]]>http://example.com/article5http://example.com/article5Mon, 28 May 2012 04:00:00 GMT \ No newline at end of file diff --git a/test/expectedOutput/simpleFeedFormated.xml b/test/expectedOutput/simpleFeedFormated.xml index d695919..b788381 100644 --- a/test/expectedOutput/simpleFeedFormated.xml +++ b/test/expectedOutput/simpleFeedFormated.xml @@ -67,4 +67,4 @@ Mon, 28 May 2012 04:00:00 GMT - + \ No newline at end of file From eab828f5cc285ed387360c40be3daddc236fa1af Mon Sep 17 00:00:00 2001 From: Kyle Mitchell Date: Tue, 26 May 2015 08:00:26 +0000 Subject: [PATCH 14/14] fix typo in package.json --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index aedaa0b..249f669 100644 --- a/package.json +++ b/package.json @@ -78,5 +78,5 @@ "folderify" ] }, - "licenses": "MIT" + "license": "MIT" }