From 01a202705337f67cc6f900741d515cbcd2e9402a Mon Sep 17 00:00:00 2001
From: langmi <daywalker2000@gmx.net>
Date: Sun, 4 Mar 2012 18:00:38 +0100
Subject: [PATCH] added parsing of image_url and test

---
 .gitignore   |  1 +
 lib/rss.js   | 18 +++++++++++-------
 test/test.js | 52 ++++++++++++++++++++++++++++++++++++++++++++++++----
 3 files changed, 60 insertions(+), 11 deletions(-)
 create mode 100644 .gitignore

diff --git a/.gitignore b/.gitignore
new file mode 100644
index 0000000..3c3629e
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1 @@
+node_modules
diff --git a/lib/rss.js b/lib/rss.js
index 521aea6..e77c6ee 100644
--- a/lib/rss.js
+++ b/lib/rss.js
@@ -48,13 +48,17 @@ function ifTruePush(bool, array, data) {
 function generateXML (data){
     // todo: xmlns:itunes="http://www.itunes.com/dtds/podcast-1.0.dtd"
 
-    var channel = [
-            { title:        { _cdata: data.title } },
-            { description:  { _cdata: data.description || data.title } },
-            { link:         data.site_url || 'http://github.com/dylan/node-rss' },
-            { generator:    'NodeJS RSS Module' },
-            { lastBuildDate: new Date().toGMTString() }
-            ];
+    var channel = [];
+    channel.push({ title:           { _cdata: data.title } });
+    channel.push({ description:     { _cdata: data.description || data.title } });
+    channel.push({ link:            data.site_url || 'http://github.com/dylan/node-rss' });
+    // image_url set?
+    if (data.image_url) {
+        channel.push({ image:  [ {url: data.image_url}, {title: data.title},  {link: data.site_url} ] });
+    }
+    channel.push({ generator:       'NodeJS RSS Module' });
+    channel.push({ lastBuildDate:   new Date().toGMTString() });
+
     ifTruePush(data.feed_url, channel, { 'atom:link':  { _attr: { href: data.feed_url, rel: 'self', type: 'application/rss+xml' } } });
     //            { updated:      new Date().toGMTString() }
 
diff --git a/test/test.js b/test/test.js
index f6f915b..66ecc5b 100644
--- a/test/test.js
+++ b/test/test.js
@@ -29,27 +29,71 @@ module.exports = {
                     title:  'item 1',
                     description: 'description 1',
                     url: 'http://example.com/article1',
-                    date: 'May 24, 2012'
+                    date: 'May 24, 2012 04:00:00 GMT'
                 })
             .item({
                     title:  'item 2',
                     description: 'description 2',
                     url: 'http://example.com/article2',
-                    date: 'May 25, 2012'
+                    date: 'May 25, 2012 04:00:00 GMT'
                 })
             .item({
                     title:  'item 3',
                     description: 'description 3',
                     url: 'http://example.com/article3',
                     guid: 'item3',
-                    date: 'May 26, 2012'
+                    date: 'May 26, 2012 04:00:00 GMT'
                 })
             .item({
                     title:  'item 4 & html test with <strong>',
                     description: 'description 4 uses some <strong>html</strong>',
                     url: 'http://example.com/article4?this&that',
                     author: 'Guest Author',
-                    date: 'May 27, 2012'
+                    date: 'May 27, 2012 04:00:00 GMT'
+                });
+
+        var expectedResult = '<?xml version="1.0" encoding="UTF-8"?>\n<rss xmlns:dc="http://purl.org/dc/elements/1.1/" xmlns:content="http://purl.org/rss/1.0/modules/content/" xmlns:atom="http://www.w3.org/2005/Atom" version="2.0"><channel><title><![CDATA[title]]></title><description><![CDATA[description]]></description><link>http://example.com</link><image><url>http://example.com/icon.png</url><title>title</title><link>http://example.com</link></image><generator>NodeJS RSS Module</generator><lastBuildDate>' + new Date().toUTCString() +'</lastBuildDate><atom:link href="http://example.com/rss.xml" rel="self" type="application/rss+xml"/><item><title><![CDATA[item 1]]></title><description><![CDATA[description 1]]></description><link>http://example.com/article1</link><guid isPermaLink="true">http://example.com/article1</guid><dc:creator><![CDATA[Dylan Greene]]></dc:creator><pubDate>Thu, 24 May 2012 04:00:00 GMT</pubDate></item><item><title><![CDATA[item 2]]></title><description><![CDATA[description 2]]></description><link>http://example.com/article2</link><guid isPermaLink="true">http://example.com/article2</guid><dc:creator><![CDATA[Dylan Greene]]></dc:creator><pubDate>Fri, 25 May 2012 04:00:00 GMT</pubDate></item><item><title><![CDATA[item 3]]></title><description><![CDATA[description 3]]></description><link>http://example.com/article3</link><guid isPermaLink="false">item3</guid><dc:creator><![CDATA[Dylan Greene]]></dc:creator><pubDate>Sat, 26 May 2012 04:00:00 GMT</pubDate></item><item><title><![CDATA[item 4 & html test with <strong>]]></title><description><![CDATA[description 4 uses some <strong>html</strong>]]></description><link>http://example.com/article4?this&amp;that</link><guid isPermaLink="true">http://example.com/article4?this&amp;that</guid><dc:creator><![CDATA[Guest Author]]></dc:creator><pubDate>Sun, 27 May 2012 04:00:00 GMT</pubDate></item></channel></rss>';
+        var result = feed.xml();
+
+        test.equal(result.length, expectedResult.length);
+        test.equal(result, expectedResult);
+        test.done();
+    },
+
+    'easy test without image_url': function(test) {
+        var feed = new RSS({
+                    title: 'title',
+                    description: 'description',
+                    feed_url: 'http://example.com/rss.xml',
+                    site_url: 'http://example.com',
+                    author: 'Dylan Greene'
+                });
+
+        feed.item({
+                    title:  'item 1',
+                    description: 'description 1',
+                    url: 'http://example.com/article1',
+                    date: 'May 24, 2012 04:00:00 GMT'
+                })
+            .item({
+                    title:  'item 2',
+                    description: 'description 2',
+                    url: 'http://example.com/article2',
+                    date: 'May 25, 2012 04:00:00 GMT'
+                })
+            .item({
+                    title:  'item 3',
+                    description: 'description 3',
+                    url: 'http://example.com/article3',
+                    guid: 'item3',
+                    date: 'May 26, 2012 04:00:00 GMT'
+                })
+            .item({
+                    title:  'item 4 & html test with <strong>',
+                    description: 'description 4 uses some <strong>html</strong>',
+                    url: 'http://example.com/article4?this&that',
+                    author: 'Guest Author',
+                    date: 'May 27, 2012 04:00:00 GMT'
                 });
 
         var expectedResult = '<?xml version="1.0" encoding="UTF-8"?>\n<rss xmlns:dc="http://purl.org/dc/elements/1.1/" xmlns:content="http://purl.org/rss/1.0/modules/content/" xmlns:atom="http://www.w3.org/2005/Atom" version="2.0"><channel><title><![CDATA[title]]></title><description><![CDATA[description]]></description><link>http://example.com</link><generator>NodeJS RSS Module</generator><lastBuildDate>' + new Date().toUTCString() +'</lastBuildDate><atom:link href="http://example.com/rss.xml" rel="self" type="application/rss+xml"/><item><title><![CDATA[item 1]]></title><description><![CDATA[description 1]]></description><link>http://example.com/article1</link><guid isPermaLink="true">http://example.com/article1</guid><dc:creator><![CDATA[Dylan Greene]]></dc:creator><pubDate>Thu, 24 May 2012 04:00:00 GMT</pubDate></item><item><title><![CDATA[item 2]]></title><description><![CDATA[description 2]]></description><link>http://example.com/article2</link><guid isPermaLink="true">http://example.com/article2</guid><dc:creator><![CDATA[Dylan Greene]]></dc:creator><pubDate>Fri, 25 May 2012 04:00:00 GMT</pubDate></item><item><title><![CDATA[item 3]]></title><description><![CDATA[description 3]]></description><link>http://example.com/article3</link><guid isPermaLink="false">item3</guid><dc:creator><![CDATA[Dylan Greene]]></dc:creator><pubDate>Sat, 26 May 2012 04:00:00 GMT</pubDate></item><item><title><![CDATA[item 4 & html test with <strong>]]></title><description><![CDATA[description 4 uses some <strong>html</strong>]]></description><link>http://example.com/article4?this&amp;that</link><guid isPermaLink="true">http://example.com/article4?this&amp;that</guid><dc:creator><![CDATA[Guest Author]]></dc:creator><pubDate>Sun, 27 May 2012 04:00:00 GMT</pubDate></item></channel></rss>';