6 Commits
1.1.1 ... 1.2.0

Author SHA1 Message Date
LightAir
ec44f8e5d3 Небольшие изменения 2020-12-02 00:32:13 +03:00
LightAir
7770e925fd Добавление новых версий ноды в travis ci 2020-12-01 23:54:04 +03:00
LightAir
9864d6408a Небольшие правки. Добавил тесты на новый функционал от crackosok 2020-12-01 23:49:41 +03:00
LightAir
3d5258a6c7 Merge pull request #4 from crackosok/master
add possibility to set turbo false
2020-12-01 20:21:44 +03:00
Kirill Myagkikh
a8e4ba436c review fixes 2020-11-29 19:20:10 +05:00
Kirill Myagkikh
acd60d5922 add possibility to set turbo false 2020-11-18 15:23:38 +05:00
6 changed files with 69 additions and 40 deletions

View File

@@ -13,9 +13,4 @@ after_script:
- codeclimate-test-reporter < ./coverage/lcov.info
matrix:
include:
- node_js: '8.11.2'
before_install: npm -g i npm@2
- node_js: '6.11.2'
before_install: npm -g i npm@2
- node_js: '10.2.1'
before_install: npm -g i npm@2
- node_js: 'lts/*'

View File

@@ -4,11 +4,12 @@ const xml = require('xml');
/**
* Check first argument. If true - push last argument to second argument
*
* @param condition
* @param array
* @param data
*/
function ifTruePush(condition, array, data) {
function pushIfConditionTrue(condition, array, data) {
if (condition) {
array.push(data);
}
@@ -17,9 +18,9 @@ function ifTruePush(condition, array, data) {
/**
* @param related
* @param itemValues
* @param relatedfinity
* @param relatedInfinity
*/
function addRelated(related, itemValues, relatedfinity) {
function addRelated(related, itemValues, relatedInfinity) {
let relatedResult = related.map(function (rel) {
return {
link: [{
@@ -31,13 +32,32 @@ function addRelated(related, itemValues, relatedfinity) {
};
});
if (relatedfinity) {
if (relatedInfinity) {
relatedResult.push({
_attr: {'type': 'infinity'}
});
}
ifTruePush(related, itemValues, {'yandex:related': relatedResult});
pushIfConditionTrue(related, itemValues, {'yandex:related': relatedResult});
}
/**
* @param item
* @param itemValues
*/
function pushGoals(item, itemValues) {
if (item.goals.length > 0) {
item.goals.forEach(goal => itemValues.push({
'turbo:goal': {
_attr: {
type: goal.type || 'yandex',
'turbo-goal-id': goal.id,
name: goal.name,
id: goal.counter_id,
}
}
}));
}
}
/**
@@ -47,17 +67,16 @@ function addRelated(related, itemValues, relatedfinity) {
*/
function items(items, channel) {
items.forEach(function (item) {
let item_values = [];
item_values.push({_attr: {'turbo': 'true'}});
item_values.push({link: item.url});
let itemValues = [];
itemValues.push({_attr: {'turbo': item.turboEnabled ? 'true' : 'false'}});
itemValues.push({link: item.url});
ifTruePush(item.turboSource, item_values, {'turbo:source': item.turboSource});
ifTruePush(item.turboTopic, item_values, {'turbo:topic': item.turboTopic});
ifTruePush(item.date, item_values, {pubDate: new Date(item.date).toUTCString()});
ifTruePush(item.author, item_values, {author: item.author});
pushIfConditionTrue(item.turboSource, itemValues, {'turbo:source': item.turboSource});
pushIfConditionTrue(item.turboTopic, itemValues, {'turbo:topic': item.turboTopic});
pushIfConditionTrue(item.date, itemValues, {pubDate: new Date(item.date).toUTCString()});
pushIfConditionTrue(item.author, itemValues, {author: item.author});
let img = '';
let menu = '';
let img = '', menu = '';
if (item.image_url) {
img = '<figure><img src="' + item.image_url + '" /></figure>';
@@ -71,26 +90,15 @@ function items(items, channel) {
let fullContent = '<header>' + img + ' <h1>' + item.title + '</h1>' + menu + '</header>' + item.content;
if (item.goals.length > 0) {
item.goals.forEach(goal => item_values.push({
"turbo:goal": {
_attr: {
type: goal.type || 'yandex',
'turbo-goal-id': goal.id,
name: goal.name,
id: goal.counter_id,
}
}
}))
}
pushGoals(item, itemValues);
item_values.push({'turbo:content': {_cdata: fullContent}});
itemValues.push({'turbo:content': {_cdata: fullContent}});
if (typeof item.related !== 'undefined') {
addRelated(item.related, item_values, item.relatedfinity);
addRelated(item.related, itemValues, item.relatedfinity);
}
channel.push({item: item_values});
channel.push({item: itemValues});
});
}
@@ -143,6 +151,7 @@ function itemData(data) {
turboSource: data.turboSource || '',
turboTopic: data.turboTopic || '',
goals: data.goals || [],
turboEnabled: data.turboEnabled !== undefined ? data.turboEnabled: true,
};
}
/**

View File

@@ -1,6 +1,6 @@
{
"name": "turbo-rss",
"version": "1.1.0",
"version": "1.1.1",
"description": "RSS based, feed generator for Yandex turbo",
"keywords": [
"yandex",

View File

@@ -46,7 +46,7 @@ feed.item(itemOptions);
* `turboSource` _optional_ **string** URL страницы-источника, который можно передать в Яндекс.Метрику.
* `turboTopic` _optional_ **string** Заголовок страницы, который можно передать в Яндекс.Метрику.
* `goals` _optional_ **array** массив типа: { _id_ - внутренний идентификатор цели (turbo-goal-id), _name_ - имя цели, _counter_id_ - id счётчика яндекс-метрики }
* `turboEnabled`_optional_ **bool** Принудительная установка атрибута "turbo". По умолчанию true. Установка в false позволит скрыть отображение турбо-страницы
###### menu array
menu должен содержать массив объектов со следующими опциями:
@@ -119,3 +119,11 @@ var xml = feed.xml();
```sh
$ npm test
```
## Спасибо
@jahglow
@vvmspace
@crackosok

View File

@@ -0,0 +1 @@
<rss xmlns:yandex="http://news.yandex.ru" xmlns:media="http://search.yahoo.com/mrss/" xmlns:turbo="http://turbo.yandex.ru" version="2.0"><channel><title><![CDATA[title]]></title><link>http://example.com/rss.xml</link><description><![CDATA[description]]></description><language>ru</language><item turbo="false"><link></link><turbo:content><![CDATA[<header> <h1></h1></header>undefined]]></turbo:content></item></channel></rss>

View File

@@ -1,7 +1,7 @@
// prova is a wrapper for tape
// use npm run test:browser to run tests in a browser
/*
* use npm test to run tests
*/
const test = require('tape');
const TR = require('..');
const includeFolder = require('include-folder');
@@ -31,6 +31,22 @@ test('default item', function (t) {
t.equal(feed.xml(), expectedOutput.defaultItem.trim());
});
test('default item turbo false', function (t) {
t.plan(1);
let feed = new TR({
title: 'title',
description: 'description',
link: 'http://example.com/rss.xml',
site_url: 'http://example.com',
});
feed.item({
turboEnabled: false
});
t.equal(feed.xml(), expectedOutput.defaultItemTurboFalse.trim());
});
test('related item', function (t) {
t.plan(1);
let feed = new TR({